-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run org.kordamp.maven:pomchecker-maven-plugin:1.10.0:check-maven-central
#491
Conversation
Looks good. No mutations were possible for these changes. |
The plugin (unconditionally) emits warnings such as:
This is fair. We should indeed either override/duplicate this property, and/or update the website to provide some documentation for each module. Suppressing the warning requires the former, but before I do so: @rickie any thoughts on using the same URL (i.e. the home page) everywhere, vs. creating sub-pages? Perhaps a page in which we describe the project structure could be helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Configuration looks good.
I agree that having a page per module would be nice and should definitely be the end goal. For now we can duplicate the URL indeed and start working on an overview page after that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀
b287d73
to
f127ff5
Compare
SGTM! Added a commit. Will you track the follow-up work? |
Looks good. No mutations were possible for these changes. |
f127ff5
to
76c2dff
Compare
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickie @chamil-prabodha the PR was simplified; PTAL. (The build fails because of the <requirePluginVersions />
check; that's expected for now.)
pom.xml
Outdated
<plugin> | ||
<groupId>org.kordamp.maven</groupId> | ||
<artifactId>pomchecker-maven-plugin</artifactId> | ||
<version>1.8.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I upgraded to this SNAPSHOT to test kordamp/pomchecker#9; works nicely! We can merge once 1.8.0 is released :)
76c2dff
to
78095c9
Compare
org.kordamp.maven:pomchecker-maven-plugin:1.7.0:check-maven-central
org.kordamp.maven:pomchecker-maven-plugin:1.8.0:check-maven-central
Looks good. No mutations were possible for these changes. |
Rebased, added a commit and updated the suggested commit message. But the build now fails on:
So this PR is now blocked for the same reason that #434 is. |
Oke thanks for updating though, will add |
78095c9
to
2e68579
Compare
Looks good. No mutations were possible for these changes. |
By now version 1.9.0 is out, and it too requires Maven 3.9.0. So this upgrade is still blocked on #434. |
2e68579
to
22d48b6
Compare
Looks good. No mutations were possible for these changes. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
22d48b6
to
2a58f00
Compare
Looks good. No mutations were possible for these changes. |
org.kordamp.maven:pomchecker-maven-plugin:1.8.0:check-maven-central
org.kordamp.maven:pomchecker-maven-plugin:1.10.0:check-maven-central
Bumped to version 1.10.0. This PR will be unblocked by #964. |
…ral` This new Maven goal validates that the `pom.xml` files meet the criteria for being deployed to Maven Central.
2a58f00
to
6757e44
Compare
Looks good. No mutations were possible for these changes. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Suggested commit message: