Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run org.kordamp.maven:pomchecker-maven-plugin:1.10.0:check-maven-central #491

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Feb 5, 2023

Suggested commit message:

Run `org.kordamp.maven:pomchecker-maven-plugin:1.10.0:check-maven-central` (#491)

This new Maven goal validates that the `pom.xml` files meet the criteria
for being deployed to Maven Central. 

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

The plugin (unconditionally) emits warnings such as:

[INFO] --- pomchecker-maven-plugin:1.7.0:check-maven-central (check-maven-central-compliance) @ refaster-compiler ---
[WARN] <url> is not defined in POM. Will use computed value from parent: 
	https://error-prone.picnic.tech/refaster-compiler

This is fair. We should indeed either override/duplicate this property, and/or update the website to provide some documentation for each module. Suppressing the warning requires the former, but before I do so: @rickie any thoughts on using the same URL (i.e. the home page) everywhere, vs. creating sub-pages? Perhaps a page in which we describe the project structure could be helpful.

Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Configuration looks good.

@rickie
Copy link
Member

rickie commented Feb 7, 2023

I agree that having a page per module would be nice and should definitely be the end goal.

For now we can duplicate the URL indeed and start working on an overview page after that?

Copy link
Contributor

@chamil-prabodha chamil-prabodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@Stephan202 Stephan202 force-pushed the sschroevers/enable-pom-checker branch from b287d73 to f127ff5 Compare February 9, 2023 07:03
@Stephan202
Copy link
Member Author

For now we can duplicate the URL indeed and start working on an overview page after that?

SGTM! Added a commit. Will you track the follow-up work?

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/enable-pom-checker branch from f127ff5 to 76c2dff Compare February 17, 2023 04:51
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member Author

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickie @chamil-prabodha the PR was simplified; PTAL. (The build fails because of the <requirePluginVersions /> check; that's expected for now.)

pom.xml Outdated
<plugin>
<groupId>org.kordamp.maven</groupId>
<artifactId>pomchecker-maven-plugin</artifactId>
<version>1.8.0-SNAPSHOT</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded to this SNAPSHOT to test kordamp/pomchecker#9; works nicely! We can merge once 1.8.0 is released :)

@Stephan202 Stephan202 force-pushed the sschroevers/enable-pom-checker branch from 76c2dff to 78095c9 Compare February 17, 2023 20:34
@Stephan202 Stephan202 changed the title Run org.kordamp.maven:pomchecker-maven-plugin:1.7.0:check-maven-central Run org.kordamp.maven:pomchecker-maven-plugin:1.8.0:check-maven-central Feb 17, 2023
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member Author

Rebased, added a commit and updated the suggested commit message. But the build now fails on:

The plugin org.kordamp.maven:pomchecker-maven-plugin:1.8.0 requires Maven version 3.9.0

So this PR is now blocked for the same reason that #434 is.

@rickie
Copy link
Member

rickie commented Feb 18, 2023

Oke thanks for updating though, will add pause renovate for now 😄.

@rickie rickie added pause renovate Stop automatic rebasing chore A task not related to code (build, formatting, process, ...) and removed pause renovate Stop automatic rebasing labels Feb 18, 2023
@rickie rickie force-pushed the sschroevers/enable-pom-checker branch from 78095c9 to 2e68579 Compare February 21, 2023 08:19
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie added the blocked This blocks either a release or a downstream project label Feb 28, 2023
@Stephan202
Copy link
Member Author

By now version 1.9.0 is out, and it too requires Maven 3.9.0. So this upgrade is still blocked on #434.

@Stephan202 Stephan202 force-pushed the sschroevers/enable-pom-checker branch from 2e68579 to 22d48b6 Compare August 29, 2023 06:33
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stephan202 Stephan202 force-pushed the sschroevers/enable-pom-checker branch from 22d48b6 to 2a58f00 Compare January 12, 2024 19:06
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 changed the title Run org.kordamp.maven:pomchecker-maven-plugin:1.8.0:check-maven-central Run org.kordamp.maven:pomchecker-maven-plugin:1.10.0:check-maven-central Jan 12, 2024
@Stephan202
Copy link
Member Author

Bumped to version 1.10.0. This PR will be unblocked by #964.

@Stephan202 Stephan202 force-pushed the sschroevers/enable-pom-checker branch from 2a58f00 to 6757e44 Compare January 13, 2024 16:17
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stephan202 Stephan202 removed pause renovate Stop automatic rebasing blocked This blocks either a release or a downstream project labels Jan 13, 2024
@Stephan202 Stephan202 added this to the 0.15.0 milestone Jan 13, 2024
@Stephan202 Stephan202 merged commit b8eabff into master Jan 13, 2024
16 checks passed
@Stephan202 Stephan202 deleted the sschroevers/enable-pom-checker branch January 13, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants