-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce assorted Reactor Refaster rules #763
Conversation
Looks good. No mutations were possible for these changes. |
e5bae56
to
45b40de
Compare
Looks good. No mutations were possible for these changes. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little delayed, but I (a) added two comments, and (b) suggest rebasing.
Very cool rules. 🙂
return flux.flatMapIterable(function); | ||
return Refaster.anyOf( | ||
flux.flatMapIterable(function), flux.map(function).concatMapIterable(identity())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation of this method is outdated now. 👍
@BeforeTemplate | ||
Flux<S> before( | ||
Flux<T> flux, Function<? super T, ? extends Iterable<? extends S>> function, int prefetch) { | ||
return flux.flatMapIterable(function, prefetch); | ||
return Refaster.anyOf( | ||
flux.flatMapIterable(function, prefetch), | ||
flux.map(function).concatMapIterable(identity(), prefetch)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Idem
45b40de
to
18a1528
Compare
Tnx for the review @werli! Rebased and added a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick tweaks @Stephan202 💪
Looks good. No mutations were possible for these changes. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great checks 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
Flushing a bunch of changes I had collected locally. This could be split into multiple PRs. Let me know if anybody feels strongly enough about that.
Suggested commit messages: