-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add on-demand integration test workflow #836
Conversation
Looks good. No mutations were possible for these changes. |
6 similar comments
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
testing the /integration-test command |
Looks good. No mutations were possible for these changes. |
2 similar comments
Looks good. No mutations were possible for these changes. |
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback, I know you are going to push some more changes still.
with: | ||
name: integration-test-diffs | ||
path: | | ||
./integration-tests/checkstyle-checkstyle-10.9.3-expected-changes.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use *
instead of the specific versions 😄.
See some examples here: https://github.com/actions/upload-artifact.
fetch-depth: '0' | ||
persist-credentials: false | ||
- name: Set git config | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
- name: Set up JDK | ||
uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0 # v3.13.0 | ||
with: | ||
# XXX TODO: java version matrix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets omit this for now, maybe add an XXX on the top of the file as for now.
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1 | ||
with: | ||
submodules: 'recursive' | ||
# ensure we fetch ALL commits and tags! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# ensure we fetch ALL commits and tags! | |
# Ensure that all commits and tags are being fetched. |
# if: | | ||
# github.event.issue.pull_request && | ||
# contains(github.event.comment.body, '/integration-test') | ||
# XXX TODO: Device matrix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not for now I'd say, let's omit.
# run action every time a new comment is created | ||
issue_comment: | ||
types: [ created ] | ||
# enable this, to test the action without changing default branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# enable this, to test the action without changing default branch | |
# XXX: Enable this, to test the action without changing default branch. |
@@ -0,0 +1,58 @@ | |||
name: On-demand integration test | |||
on: | |||
# run action every time a new comment is created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can omit this :).
Looks good. No mutations were possible for these changes. |
1 similar comment
Looks good. No mutations were possible for these changes. |
This reverts commit 38aa286.
b047062
to
181c046
Compare
Looks good. No mutations were possible for these changes. |
Kudos, SonarCloud Quality Gate passed! |
This PR is superseded by #865. Primary improvements in that PR:
|
No description provided.