Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around IntelliJ IDEA bug IDEA-342187 #958

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Jan 10, 2024

See #925 (comment) and #775 (comment) for context. It turns out that since #515 our IDEA setup is broken due to IDEA-342187. With these changes we can once again run all tests in IDEA.

Suggested commit message:

Work around IntelliJ IDEA bug IDEA-342187 (#958)

This reverts some of the changes in
3578a8cbec7c2d85f20ca8093e257440790d0953.

See https://youtrack.jetbrains.com/issue/IDEA-342187

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@Venorcis Venorcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@rickie rickie force-pushed the sschroevers/work-around-IDEA-342187 branch from 217e63b to 19eedb7 Compare January 13, 2024 13:45
@rickie
Copy link
Member

rickie commented Jan 13, 2024

Nice find & upstream fix 🚀!

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie added the chore A task not related to code (build, formatting, process, ...) label Jan 13, 2024
@rickie rickie merged commit f35d620 into master Jan 13, 2024
16 checks passed
@rickie rickie deleted the sschroevers/work-around-IDEA-342187 branch January 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task not related to code (build, formatting, process, ...)
Development

Successfully merging this pull request may close these issues.

3 participants