Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Coveralls with Codecov #74

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Replace Coveralls with Codecov #74

merged 1 commit into from
Sep 28, 2019

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Sep 28, 2019 •
edited
Loading

Rationale:

@ghost
Copy link

ghost commented Sep 28, 2019 •
edited by ghost
Loading

DeepCode Report (#9f9b32)

DeepCode analyzed this pull request.
There are no new issues.

@coveralls
Copy link

coveralls commented Sep 28, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 438

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.806%
Totals Coverage Status
Change from base Build 436: 0.0%
Covered Lines: 125
Relevant Lines: 144
💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 28, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@020b167). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage          ?   85.41%           
  Complexity        ?       54           
=========================================
  Files             ?        5           
  Lines             ?      144           
  Branches          ?        1           
=========================================
  Hits              ?      123           
  Misses            ?       19           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020b167...9f9b320. Read the comment docs.

@Stephan202 Stephan202 changed the base branch from sschroevers/use-oss-parent to master September 28, 2019 19:15
@Stephan202
Replace Coveralls with Codecov
9f9b320 
Rationale:
- Coveralls is occasionally unstable, with recently an extended outage.
- trautonen/coveralls-maven-plugin#112 is still not resolved.
- The Codecov user interface is clearer.
- We use Codecov also for an internal project.
@Stephan202 Stephan202 changed the title Introduce Codecov Replace Coveralls with Codecov Sep 28, 2019
Stephan202 added a commit to PicnicSupermarket/oss-parent that referenced this pull request Sep 28, 2019
@Stephan202
Drop the coveralls-maven-plugin
2a755cd 
We'll use Codecov instead; see PicnicSupermarket/jolo#4 and
PicnicSupermarket/reactive-support#74.
Stephan202 added a commit to PicnicSupermarket/oss-parent that referenced this pull request Sep 28, 2019
@Stephan202
Drop coveralls-maven-plugin
2c273c3 
We'll use Codecov instead; see PicnicSupermarket/jolo#4 and
PicnicSupermarket/reactive-support#74.
@Stephan202 Stephan202 mentioned this pull request Sep 28, 2019
Merged
Mordavolt
Mordavolt approved these changes Sep 28, 2019
View reviewed changes
Copy link

@Mordavolt Mordavolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stephan202 Stephan202 merged commit b75edc2 into master Sep 28, 2019
@Stephan202 Stephan202 deleted the sschroevers/codecov branch September 28, 2019 21:10
Stephan202 added a commit to PicnicSupermarket/oss-parent that referenced this pull request Sep 28, 2019
@Stephan202
Drop coveralls-maven-plugin (#3)
5a923c0 
We'll use Codecov instead; see PicnicSupermarket/jolo#4 and
PicnicSupermarket/reactive-support#74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mordavolt Mordavolt Mordavolt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @coveralls @Mordavolt