Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add static to shared functions #1114

Merged
merged 1 commit into from
Oct 18, 2023
Merged

add static to shared functions #1114

merged 1 commit into from
Oct 18, 2023

Conversation

ksyeo1010
Copy link
Contributor

@ksyeo1010 ksyeo1010 commented Oct 18, 2023 •
edited
Loading

need to add static cause some fn's share same name as rhino, interferes while building

@ksyeo1010 ksyeo1010 requested a review from laves October 18, 2023 00:17
@laves laves merged commit db95052 into v3.0 Oct 18, 2023
30 checks passed
@ksyeo1010 ksyeo1010 deleted the v3.0-go-update branch October 25, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laves laves laves approved these changes

Assignees

@laves laves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksyeo1010 @laves