Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Workarounds To Readme.md #891

Merged
merged 34 commits into from
Nov 6, 2022
Merged

Add Workarounds To Readme.md #891

merged 34 commits into from
Nov 6, 2022

Conversation

Serkali-sudo
Copy link
Contributor

@Serkali-sudo Serkali-sudo commented Oct 19, 2022 •
edited
Loading

I combined them all in the readme file.
#885 (comment)

@PierfrancescoSoffritti
Copy link
Owner

Thanks for putting this together! can you send the PR to the dev branch? i will review it sometime this week :)

@Serkali-sudo Serkali-sudo changed the base branch from master to dev October 19, 2022 13:00
PierfrancescoSoffritti
PierfrancescoSoffritti reviewed Nov 5, 2022
View reviewed changes
Copy link
Owner

@PierfrancescoSoffritti PierfrancescoSoffritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have take the liberty to rephrase some some of the text. Let me know what you think.

The idea is to give general guidance instead of a step-by-step tutorial.

README.md Outdated Show resolved Hide resolved
README.md Outdated
}
```

## Play Next Video
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not super clear to me what this workaround does, can you please try to explain a bit better? why would someone want to use it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that code basically gets YouTube video from "more video"(you can think of it like recommendation section on YouTube) so if you want to play next recommended video.It is like "auto play" function on YouTube. I personally call that code from YT.PlayerState.ENDED so when video ends it automatically plays the next recommended video.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that makes sense, thanks for the explanation.

@PierfrancescoSoffritti PierfrancescoSoffritti merged commit 2ad942a into PierfrancescoSoffritti:dev Nov 6, 2022
@PierfrancescoSoffritti
Copy link
Owner

thanks for the help @Serkali-sudo

PierfrancescoSoffritti pushed a commit to Praveen-Pable/android-youtube-player that referenced this pull request Mar 13, 2023
@Serkali-sudo
Add Workarounds To Readme.md (PierfrancescoSoffritti#891)
a64f078 
Add FAQ section to README with workarounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierfrancescoSoffritti PierfrancescoSoffritti PierfrancescoSoffritti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serkali-sudo @PierfrancescoSoffritti