Zod schema validation #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profound change in how state is defined and persisted on disk to better clarify each component role, how to implement components per provider and implement saner and easier to test components. Each component now have clearly identified side effects so it's easier to mock with unit tests.
Mocha was incredibly slow. This issue recommands transpile-only: TypeStrong/ts-node#754 (comment)
for better testability and control over data and side effects
Big InstanceManager class with generic was a pain to manage and caused Zod implementation to be painful. Rather, use a factory pattern with a generic InstanceManager. Depending on State and provider in state, implement the InstanceManager with expected sub-Managers for specific provider. This also provide a better separation of concern between high-level InstanceManager (not knowing concrete state type or provider) and provider-specific implementation. Also started a bit of Zod implementation. No major impact yet.
…d other tasks along with cleaning-up legacy state added a few tests to make sure
Will provide more safety when loading and saving file to disk, otherwie we may load data not matching Typescript typing and breaking things in unexpected manners.
introduced by recent commits on this branch, not a fix
introduced a tiny bug and forgot a commen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.