Skip to content

Fix terminal resize on Windows PowerShell #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierrunoYT merged 3 commits into from
Dec 20, 2025
Merged

Fix terminal resize on Windows PowerShell #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d92d5de
Initial plan
Copilot Dec 20, 2025
f48d10d
Add SIGWINCH listener for terminal resize on Windows PowerShell
Copilot Dec 20, 2025
0f35907
Address code review feedback: extract JSX and clarify comments
Copilot Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions cli/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,28 @@ async function main(): Promise<void> {
backgroundColor: 'transparent',
exitOnCtrlC: false,
})
createRoot(renderer).render(

const root = createRoot(renderer)

// React component tree to render
const app = (
<QueryClientProvider client={queryClient}>
<AppWithAsyncAuth />
</QueryClientProvider>,
</QueryClientProvider>
)

// Add resize event listener for terminal resize support on Windows PowerShell
// On Windows, the SIGWINCH signal may not fire reliably, so we listen to
// process.stdout 'resize' event to ensure the UI updates when the window is resized
if (process.stdout.isTTY) {
process.stdout.on('resize', () => {
// Re-render the React tree to update with new terminal dimensions
root.render(app)
})
Copy link

@cursor cursor bot Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same JSX element reference may prevent re-renders on resize

The app JSX element is stored as a constant and reused when calling root.render(app) on resize. React's reconciliation compares the new element with the current one, and since it's the same object reference with identical props, React may bail out and skip re-rendering the component tree. This would prevent useTerminalDimensions from being called again to query updated dimensions. To force a re-render, the JSX should be created fresh each time (e.g., via a function that returns the JSX) or use a mechanism like a changing key prop to signal React that a re-render is needed.

Fix in Cursor Fix in Web

}

// Initial render
root.render(app)
}

void main()
Loading