^ Update os references in action configs

[PikachuEXE]

Ubuntu latest will soon be switched to 24 LTS

[PikachuEXE]

@toobuntu See if you want to take a look

[toobuntu]

Some general thoughts:

• Glad to see this. I had been working on a similar PR but haven't had time to finish it.
• With macOS Sequoia, Apple removed the Ctrl-click method to override Gatekeeper. As I understand it, if software cannot be run on macOS, Homebrew will eventually deprecate and then disable and remove it from its ecosystem.[1,2] So FreeTube might want to reconsider hosting an official tap for both Intel and Apple Silicon casks, with the --no-quarantine instruction. Or you could add Intel to this tap.
• Now that macos-latest points to macos-14, I would say reduce the future maintenance burden by using macos-latest and ubuntu-latest everywhere.
• Although the Homebrew Docker image is on hub, the Homebrew project leader prefers to use ghcr.io: . You can find ubuntu24.04 here: https://github.com/orgs/Homebrew/packages?repo_name=brew.
• In general, the Actionlint part of things in this tap's CI has become a bit of a mess. The ETags still update but not the content anymore, and upstream is now uploading CodeQL CLI SARIF output. In other words, I think it's time to diverge from upstream and stop trying to sync with its changes. We can take a look at the Actionlint workflow and make it good enough for this tap and leave it at that.

[1] Homebrew/brew#16752
[2] https://github.com/Homebrew/brew/blob/master/Library/Homebrew/deprecate_disable.rb#L28-L30

[PikachuEXE]

• Official tap: Not sure how the team think probably won't do much until someone reported the issue and can be reproduced (or any sign or removing the formula). There is a PR to build mac-arm64 version (too lazy to find now) but that does not imply an official tap.
• macos-14: I think I have changed all macos-14 but let me recheck.
• Docker image: I tried twice already: https://github.com/PikachuEXE/homebrew-FreeTube/actions/runs/12309161448?pr=51 & https://github.com/PikachuEXE/homebrew-FreeTube/actions/runs/12309128506?pr=51. Let me know if there is tag that I can use
• Actionlint: I know nothihg about it, just make it do basic validations and ya no need to be completely the same as upstream. Another PR though

[toobuntu]

I see you tried

• ghcr.io/homebrew/ubuntu24.04:master, which does not exist for 24.04. So I would expect that to fail.
• ghcr.io/homebrew/ubuntu24.04:cache, which does exist. I don't know why it failed.

[toobuntu]

Have you tried ghcr.io/homebrew/ubuntu24.04:latest?
It worked over here: https://github.com/jck112/homebrew-cask/actions/runs/12326368226/job/34407056594.

[toobuntu]

Suggested change

	# macos-latest refers to macOS 14 Arm64
	# macos-latest refers to macOS on arm64

To avoid having to update this when latest refers to 15+, might as well just reference the important part which is that we need arm and latest is now arm instead of Intel.

[PikachuEXE]

Updated

[toobuntu]

LGTM

[PikachuEXE]

Should we just remove .github/workflows/update-actionlint-workflow.yml since there is really no need to update it to be like upstream? (besides it keep creating PRs about etag changes

[toobuntu]

Yes, and there is no need to keep the etags dir around, either.

rm -rf .github/workflows/update-actionlint-workflow.yml .github/etags