Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXAMPLE] Moving Square #14

Merged
merged 7 commits into from
Sep 5, 2021
Merged

[EXAMPLE] Moving Square #14

merged 7 commits into from
Sep 5, 2021

Conversation

abdothegreat
Copy link
Contributor

The run.ps1 file uses mingw32-make so you may need to change that.

@OkiStuff
Copy link
Contributor

Thanks for the PR! I'll start reviewing it

@OkiStuff OkiStuff self-requested a review August 15, 2021 16:01
@OkiStuff OkiStuff changed the title Added example where users can move around a square with WASD [EXAMPLE] Moving Square Aug 15, 2021
@OkiStuff
Copy link
Contributor

@abdothegreat The code is fine but has a few problems. In the pong example, there is still a build folder. Before committing any code please make sure no build folder is there. And could you change the name of the folder from Moving-character to just "moving_square" so it fits with the naming scheme of all the other folders? Thanks!

Copy link
Contributor

@OkiStuff OkiStuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the build folder in the pong example and remove the Moveable-character folder to just "moving_square". Also make sure to change the code following the review comments

begin_drawing();
clear_screen(my_color);

if(key_down(&applet, KEY_W)&&player.y!=5) player.y -=5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Index is weird here


int main(void)
{
applet = InitializeApplet(SCREEN_WIDTH, SCREEN_HEIGHT, "Muzzle [CORE] - Blank Window", MUZZLE_FALSE, MUZZLE_TRUE);
Copy link
Contributor

@OkiStuff OkiStuff Aug 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and please change the title to Muzzle [EXAMPLE] - Moving Square

.x = 225,
.y = 225
};
tint my_color = {84, 84, 84, 255};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. this exact color has been changed to GRAY

while (keep_applet(applet.window_handle))
{
begin_drawing();
clear_screen(my_color);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of my_color you can use GRAY

@@ -0,0 +1,80 @@
set(CMAKE_C_COMPILER "C:/Users/Abdel Rahman/Downloads/mingw-w64/i686-8.1.0-posix-dwarf-rt_v6-rev0/mingw32/bin/gcc.exe")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

@@ -0,0 +1,91 @@
set(CMAKE_CXX_COMPILER "C:/Users/Abdel Rahman/Downloads/mingw-w64/i686-8.1.0-posix-dwarf-rt_v6-rev0/mingw32/bin/g++.exe")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

@@ -0,0 +1,6 @@
set(CMAKE_RC_COMPILER "C:/Users/Abdel Rahman/Downloads/mingw-w64/i686-8.1.0-posix-dwarf-rt_v6-rev0/mingw32/bin/windres.exe")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the entire build directory

@OkiStuff
Copy link
Contributor

OkiStuff commented Sep 5, 2021

Sorry for forgetting about this, merging it rn. thanks

@OkiStuff OkiStuff closed this Sep 5, 2021
@OkiStuff OkiStuff reopened this Sep 5, 2021
@OkiStuff OkiStuff merged commit b249d4e into PikoStudios:main Sep 5, 2021
@OkiStuff OkiStuff added the 2.0 label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants