-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shaders + Matrix: Added mat3 and mat4 #36
Shaders + Matrix: Added mat3 and mat4 #36
Conversation
It seems as if I removed the newlines at the end of the files, due to unix encoding. Was worried that would happen. Let me know if thats a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, just one thing:
- The mat3 and mat4 types do not specify size, it is not guaranteed that these are an array, simply a pointer to a float, or an array that does not match the needed size.
typedef int array_type_example[5]; array_type_example my_array = {1,2,3,4,5}
. - It may also be a good idea to check if the array is NULL, but I can implement that as I want to rework assertions in Muzzle.
What exactly should be done if the array is NULL? Should I check the entire array's size for NULL? |
No, just the pointer. Also use |
7368465
to
b54f056
Compare
b54f056
to
cc913d3
Compare
Also replaced error checking with TODO as I need to revamp MZ_ASSERT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything Looks good!
NOTE: Commit was squashed into one commit. |
This PR implements the matrix support outlined in issue #34. All commits are non-breaking and can be found in
include\modern_pipeline\shaders.h
,Shaders.c
andinclude\core\matrix.h