Skip to content

Feat(client): 개발 QA 1차(사이드바 카테고리 이모지 카운트 수정) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjangminii merged 1 commit into from
Sep 20, 2025
Merged

Feat(client): 개발 QA 1차(사이드바 카테고리 이모지 카운트 수정) #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions apps/client/src/shared/components/sidebar/PopupPortal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { createPortal } from 'react-dom';
import { useEffect, useState } from 'react';
import { AutoDismissToast, Popup, Toast } from '@pinback/design-system/ui';
import type { PopupState } from '@shared/hooks/useCategoryPopups';
import { graphemeLength } from '@shared/utils/grapheme';

interface Props {
popup: PopupState | null;
Expand Down Expand Up @@ -42,9 +43,9 @@ export default function PopupPortal({
if (!popup) return null;

const value = draft.trim();
const len = value.length;
const glen = graphemeLength(value);

const isEmpty = popup.kind !== 'delete' && len === 0;
const isEmpty = popup.kind !== 'delete' && glen === 0;
const isDuplicate =
popup.kind !== 'delete' &&
!!categoryList?.some(
Expand All @@ -58,10 +59,10 @@ export default function PopupPortal({
if (isDuplicate) {
helperText = '이미 존재하는 카테고리 이름입니다.';
isErrorUI = true;
} else if (len > MAX_LEN) {
} else if (glen > MAX_LEN) {
helperText = `카테고리 이름은 ${MAX_LEN}자 이내로 입력해주세요.`;
isErrorUI = true;
} else if (len === MAX_LEN) {
} else if (glen === MAX_LEN) {
helperText = `최대 ${MAX_LEN}자까지 입력할 수 있어요.`;
isErrorUI = false;
}
Expand All @@ -73,7 +74,7 @@ export default function PopupPortal({
};

const blocked =
popup.kind !== 'delete' && (isEmpty || isDuplicate || len > MAX_LEN);
popup.kind !== 'delete' && (isEmpty || isDuplicate || glen > MAX_LEN);

const handleCreate = () => {
if (blocked) return;
Expand Down
7 changes: 7 additions & 0 deletions apps/client/src/shared/utils/grapheme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
const _seg =
typeof Intl !== 'undefined' && Intl.Segmenter
? new Intl.Segmenter('ko', { granularity: 'grapheme' })
: null;

export const graphemeLength = (s: string) =>
_seg ? Array.from(_seg.segment(s)).length : Array.from(s).length;
Loading