-
Notifications
You must be signed in to change notification settings - Fork 1
Feat(재림): QA 반영 | 대시보드 랜딩 및 익스텐션 팝업 추가 수정 #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9333e39
feat: 온보딩 랜딩 분기 추가
jllee000 679b3f0
feat: 이메일 로컬스토리지 저장
jllee000 607759c
Merge remote-tracking branch 'origin/develop' into feat/#109/jl-QA-2
jllee000 6a064db
feat: 로컬스토리지 저장 방식 수정
jllee000 9a88958
feat: dateTIme 공컴 로직 수정
jllee000 4c6e350
feat: 타임피커 취소버튼 기능 수정
jllee000 8c5eca3
feat: 리마인드 타임 전닫ㄹ
jllee000 2275203
feat: 초기 생성팝업 시, get리마인드 시간으로 세팅
jllee000 ffcba4e
feat: 카테고리 추가 바로 반영 로직
jllee000 1419a3f
feat: 온보딩 fcm 지점 수정 및 스토리지 네이밍 수종
jllee000 0168c30
feat: 아이콘 이미지 수정
jllee000 0875203
feat: 스텝 분기 맥 아닐때 로직 수정
jllee000 faff62a
feat: 개발용 주석 제거
jllee000 328f78e
feat: 콘솔로그 제거하기
jllee000 86e003b
feat: 카테고리 업데이트 시점 수정
jllee000 24fceed
feat: 콘솔 제거
jllee000 e3ac97a
feat: 카테고리 추가버튼 10개이상 때 삭제
jllee000 94c82fb
feat: 대시보드 이동 크롬방식으로
jllee000 c5c7d4f
feat: 팝 창닫기 로직 복구
jllee000 5de163f
feat: 리마인드 시간 null 경우 적용
jllee000 6a4ca39
chore: 머지 충돌에러 수정
jllee000 60908e1
feat: 익스텐션 랜딩 도메인 수정
jllee000 67dce9d
feat: 익스텐션 팝업 리마인드 토글 true 및 메모 글자수 반영
jllee000 b3cbad5
feat: 수정 시에 토스트 띄우기
jllee000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
전역 상수(AlarmsType) 직접 변이 및 시간 포맷 불일치
최소 수정으로는 저장 시 24시간 포맷으로 정규화하여 넣어주세요(AM/PM 미지정 시 '오전/오후' 매핑). 주석 로그는 제거 권장.
아래 diff를 적용하면 파싱 실패를 방지하며 표시도 단순화됩니다.
}) => { - const formatted = `${meridiem} ${hour}:${minute}`; - AlarmsType[2].time = formatted; - setShowPicker(false); - // 이거 나중에 api 연결때 쓸려고 표시한거.. 그떄 지우겠듬여 console.log('저장된 사용자 알람:', AlarmsType[2].time); + // AM/PM 미정규 표기(오전/오후) 대응 후 24h 포맷으로 저장 + const merMap: Record<string, string> = { 오전: 'AM', 오후: 'PM' }; + const mer = merMap[meridiem] ?? meridiem; + const normalized = normalizeTime(`${mer} ${hour}:${minute}`); + AlarmsType[2].time = normalized; + setShowPicker(false); };추가로 권장(선택): 전역 상수 변이 대신 로컬 상태로 관리하세요.
또한 하드코딩 인덱스(2)는 상수로 추출해 의미를 드러내면 안전합니다(e.g., const CUSTOM_ALARM_INDEX = 2).
검증: 레포 전체에서 AlarmsType[2] 사용이 더 있는지 확인해 주세요.
🏁 Script executed:
Length of output: 1394
중요: AlarmsType 전역 직접 변경 금지 및 시간 포맷 정규화 필요
검증: apps/client/src/pages/onBoarding/components/funnel/AlarmBox.tsx — 37행(할당), 70–73행(표시)에서 AlarmsType[2].time 사용 확인.
🤖 Prompt for AI Agents