!HOTFIX(client): 리마인드 카드 시간 로직 변경#178
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded@constantly-dev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 48 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Walkthrough리마인드 표시 기간을 “remindAt부터 24시간”으로 재정의하고, 카드의 남은 시간 계산을 이에 맞춰 변경했습니다. 토큰 재발급 실패 시 localStorage에서 email을 삭제하던 로직을 클라이언트/익스텐션 axios 인스턴스에서 제거했습니다. 공개 API 시그니처 변화는 없습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant RemindPage as Remind Page
participant Store as Data Store
User->>RemindPage: Open Remind
RemindPage->>Store: Fetch remind items
Store-->>RemindPage: Items(remindAt)
note over RemindPage: Now ∈ [remindAt, remindAt+24h)
RemindPage-->>User: Render items filtered by new 24h window
sequenceDiagram
autonumber
participant App as App (Client/Extension)
participant Axios as AxiosInstance
participant API as Backend
participant LS as localStorage
App->>Axios: Request
Axios->>API: Send with token
API-->>Axios: 401 Unauthorized
Axios->>API: Refresh token
alt refresh fails
Axios->>LS: removeItem('token')
note right of Axios: email 보존 (remove 중단)
Axios-->>App: Redirect to onboarding + error
else refresh succeeds
Axios->>API: Retry with new token
API-->>Axios: 200 OK
Axios-->>App: Response
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Storybook chromatic 배포 확인: |
jjangminii
left a comment
There was a problem hiding this comment.
고생하셨습니다~~ 확실히 의도된대로 동작중이었지만 기획팀과 소통 오류가 있었네요..
📌 Related Issues
📄 Tasks
⭐ PR Point (To Reviewer)
기획과 개발팀 싱크가 안맞아서 로직 변경했습니다.
AS-IS
카드 남은 시간 = 리마인드 설정 시간 - 현재 시간TO-BE
카드 남은 시간 = 리마인드 시간으로부터 남은 24시간 표시크게 많이 바뀐 것은 없습니다! 약간씩만 바꾸면 가능해서 HOTFIX로 수정했습니다.
📷 Screenshot
Summary by CodeRabbit