Merged
Conversation
WalkthroughThis update enhances and refactors the test infrastructure for the application. It introduces new mocks for Redis and Firebase dependencies, restructures test base classes, adds cleanup routines for push subscriptions, updates test configuration files, and introduces a placeholder Firebase service account for testing. Some obsolete configuration files and annotations are removed. Changes
Sequence Diagram(s)sequenceDiagram
participant TestClass
participant MockedRedis
participant MockedFirebase
participant CustomRepository
TestClass->>MockedRedis: Inject mocked Redis beans
TestClass->>MockedFirebase: Inject mocked Firebase beans
TestClass->>CustomRepository: Use repository for test operations
TestClass->>CustomRepository: AfterEach: clearAndReset()
CustomRepository->>Database: Delete from article, push_subscription, category, users
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 PR 요약
지저분한 테스트 설정들을 리펙토링 했습니다.
✨ PR 상세 내용
🚨 주의 사항
나중에 레디스, 파이어베이스 관련 테스트 할때는 또 설정을 좀 바꿔야 해요 ㅎ ;;
✅ 체크 리스트
Summary by CodeRabbit
Tests
Chores
New Features