-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipelines/pingcap/tidb/latest): enable coverage upload in job #2342
Conversation
Potential problems:
Fixing suggestions:
|
Co-authored-by: wuhuizuo <wuhuizuo@126.com>
One potential problem is that the CODECOV_TOKEN is hardcoded in the script, which could lead to security vulnerabilities if the token is exposed. It might be better to use a secret management tool like Vault or store the token in an environment variable outside of the script. Another suggestion would be to add some tests for the new feature to ensure that it works as expected and does not introduce any regressions. Overall, the pull request looks good, but the potential security issue and lack of tests should be addressed before merging. |
/hold It's need to test. |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold it's passed. |
Ref: #2171 |
ref pingcap/tidb#45930