feat: Support rename explaintest to integrationtest

[Defined2014]

for pingcap/tidb#46712

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: tidb: Rename explaintest to integrationtest

Description: This PR is related to the issue pingcap/tidb#46712.

Key Changes:

1. Renamed explaintest to integrationtest in multiple Jenkins pipeline scripts.
2. Updated test commands to use integrationtest instead of explaintest.
3. Renamed explaintest.sh to integrationtest.sh.

Potential Problems:

The renaming of the test and the test script might cause issues if there are any dependencies or references to the old name (explaintest) that were not updated.

Suggestions:

1. Double-check if there are any references or dependencies on explaintest that need to be updated.
2. Test the updated pipeline scripts to ensure the renaming doesn't break any existing functionality.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title

feat: Support rename `explaintest` to `integrationtest`

Description

for https://github.com/pingcap/tidb/pull/46712

Changes

1. The main change in this PR is renaming explaintest to integrationtest, which affects the following files:

   • jenkins/pipelines/ci/tidb/tidb_ghpr_check.groovy
   • jenkins/pipelines/ci/tidb/tidb_ghpr_check_2.groovy
   • jenkins/pipelines/ci/tidb/tidb_ghpr_integration_common_test.groovy

2. The PR also updates the references to the tests in other files, such as:

   • pipelines/pingcap/tidb/*/ghpr_check2.groovy

3. The explaintest.sh script has been deleted since it's no longer in use.

Potential Problems

1. The tests might fail if the renamed integrationtest directory doesn't exist or is not properly set up.

Suggestions

1. Make sure that the integrationtest directory exists and contains all the necessary files for the tests to run correctly.

2. Update the PR description to provide more information about the motivation behind this change and how it affects the project.

3. Test the changes in a local environment or a separate testing branch to ensure that everything works as expected before merging the PR.

4. Review the code and check if any other references to explaintest need to be updated.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review Summary

Title

feat: Support rename `explaintest` to `integrationtest`

Description

for https://github.com/pingcap/tidb/pull/46712

Key Changes

• Renamed explaintest to integrationtest in several files.
• Updated file paths in test scripts and build commands to reflect the new name.

Potential Problems

• There are no apparent problems with the changes.

Suggestions

• Ensure that all references to explaintest have been updated to integrationtest.
• Verify that the test scripts and build commands work correctly with the new file paths.

Diff

diff --git a/jenkins/pipelines/ci/tidb/tidb_ghpr_check.groovy b/jenkins/pipelines/ci/tidb/tidb_ghpr_check.groovy
index 654995ca4..066472ba1 100644
--- a/jenkins/pipelines/ci/tidb/tidb_ghpr_check.groovy
+++ b/jenkins/pipelines/ci/tidb/tidb_ghpr_check.groovy
@@ -225,7 +225,7 @@ try {
                 }
             }
         }
-        tests["explaintest"] = {
+        tests["integrationtest"] = {
             run_with_pod {
                 deleteDir()
                 unstash 'tidb'
@@ -234,7 +234,7 @@ try {
                         sh """
                         go version
                         make checklist
-                        make explaintest
+                        make integrationtest
                         """
                     }
                 }
...

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Key Changes

The pull request renames the explaintest to integrationtest in various files throughout the repository. The main changes are as follows:

1. The explaintest command has been renamed to integrationtest in the CI job configuration files.
2. The explaintest.sh script has been removed.
3. The usage of the explaintest command has been replaced with the integrationtest command in several files.

Potential Problems

1. The removal of the explaintest.sh script might cause issues if there are other parts of the code that still reference it.
2. Any external tools or scripts that rely on the explaintest command will need to be updated to use the integrationtest command instead.

Fixing Suggestions

1. Ensure that there are no remaining references to the explaintest.sh script in the repository.
2. Update any external tools or scripts that rely on the explaintest command to use the integrationtest command instead.
3. Make sure to test the changes thoroughly to ensure that the renaming doesn't introduce any unintended side effects or break any existing functionality.

[wuhuizuo]

tests passed:

• https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_check2/detail/ghpr_check2/28760/pipeline/
• https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_check/detail/ghpr_check/27805/pipeline/

[wuhuizuo]

/lgtm
/approve

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-09-11 08:26:43.105562932 +0000 UTC m=+257785.030119311: ☑️ agreed by wuhuizuo.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wuhuizuo]

/hold

[wuhuizuo]

/unhold