-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tiflash): upgrade to LLVM17 & remove useless prepare tool stage #2901
feat(tiflash): upgrade to LLVM17 & remove useless prepare tool stage #2901
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
d3b2c81
to
ad471f7
Compare
This pull request seems to be about changing the version of clang-format used in the tiflash pipeline from version 12 or 15 to version 17. The pull request also updates the docker image used in the pipeline. Key changes:
Potential problems:
Fixing suggestions:
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
/cc @JaySon-Huang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
The image has contained all necessary tools.