Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts/artifacts): not override other parts in output file #2994

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind June 13, 2024 03:54
Copy link

ti-chi-bot bot commented Jun 13, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the changes in this PR involve fixing a bug where output file parts were being overridden.

The diff shows that the change is made to two files, check-images-internal.sh and check-tiup.sh. In both files, there was a line that initialized the results file with : >results.yaml. This line was changed to use the yq command to add an empty object to the images and tiup fields respectively, so that the existing content of the output file is not overridden.

There are no potential problems that are immediately apparent in this PR.

As for fixing suggestions, it would be good to add a brief explanation in the pull request description of why the yq command is used instead of simply removing the : >results.yaml line. Additionally, it might be helpful to include a test plan for how this change will be tested to ensure that the fix works as intended.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jun 13, 2024
@wuhuizuo wuhuizuo added the lgtm label Jun 13, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link

ti-chi-bot bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6f3f9f6 into main Jun 13, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the fix/check-scripts branch June 13, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant