Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temp comment cross-compile platform darwin #2999

Merged

Conversation

purelind
Copy link
Collaborator

temp comment cross-compile platform darwin. cross-compile on Linux amd64 for the platform GOOS=darwin GOARCH=amd64 will encountered error.

Copy link

ti-chi-bot bot commented Jun 14, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, it seems that the changes made are commenting out two lines of code that perform cross-compilation for the platform GOOS=darwin GOARCH=amd64. The reason for this change is that the cross-compilation on Linux amd64 for the platform GOOS=darwin GOARCH=amd64 will encounter an error.

The potential problem with this change is that it could lead to a situation where the application is not built for the darwin platform, which could cause issues during deployment.

One potential fix for this issue is to find a way to properly perform cross-compilation for the darwin platform without encountering errors. Alternatively, if cross-compilation is not possible, the application could be built natively on the darwin platform to ensure that it is properly optimized for that platform.

Additionally, it may be helpful to provide more context and details about the error that is encountered during cross-compilation to help other developers understand the issue and potential solutions.

Copy link

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 9dc807f into PingCAP-QE:main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant