-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pingcap/tidb-tools): enable new tidb-tools pipelines #3003
feat(pingcap/tidb-tools): enable new tidb-tools pipelines #3003
Conversation
Based on the PR title and description, it seems that this PR enables new tidb-tools pipelines. However, the diff only shows changes related to disabling some Jenkins pipeline jobs and modifying a Prow job configuration. The changes to disable the Jenkins pipeline jobs are concerning, as disabling jobs can potentially impact the CI/CD process and delay the detection of issues. It's important to understand why these jobs were disabled and whether it's necessary to disable them. The changes to the Prow job configuration seem reasonable, as the Fixing suggestions:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
enable new tidb-tools pipelines