-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sqllogic test pod use specify node #3017
chore: sqllogic test pod use specify node #3017
Conversation
Based on the PR title and description, it seems that the changes are related to specifying a node for the sqllogic test pod to avoid the test script from getting stuck. Looking at the diff, it appears that the change adds the There are no potential problems that I can identify from this change. However, it would be helpful if the author could provide more context on why this change was necessary and how it solves the problem. As for fixing suggestions, since this is a small change and there are no potential issues, it looks good to merge as is. However, it's always a good practice to have a peer review the code changes before merging. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨
|
User description
sqllogic test pod use specify node to avoid the test script from getting stuck
PR Type
enhancement
Description
ci-nvme-high-performance
with valuetrue
in thelatest
pipeline configuration.ci-nvme-high-performance
with valuetrue
in therelease-8.2
pipeline configuration.Changes walkthrough 📝
pod-pull_sqllogic_test.yaml
Add node selector for high-performance NVMe in latest pipeline
pipelines/pingcap/tidb/latest/pod-pull_sqllogic_test.yaml
ci-nvme-high-performance
with valuetrue
.pod-pull_sqllogic_test.yaml
Add node selector for high-performance NVMe in release-8.2 pipeline
pipelines/pingcap/tidb/release-8.2/pod-pull_sqllogic_test.yaml
ci-nvme-high-performance
with valuetrue
.