-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scripts/artifacts): fix check-tiup.sh #3023
Conversation
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Based on the Pull Request title and description, it seems that this change fixes an issue with the There are no obvious potential problems with this change. However, one suggestion for improvement could be to add more information to the Pull Request description to better explain the issue that was fixed and how this change addresses it. Additionally, it would be helpful to have some context on why the As for fixing suggestions, it seems that this change is relatively straightforward and does not require any further improvements. However, it would be good to double-check that the changes do not introduce any new issues. |
PR Reviewer Guide 🔍
|
/approve |
PR Code Suggestions ✨
|
/hold |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
User description
Signed-off-by: wuhuizuo wuhuizuo@126.com
PR Type
Bug fix
Description
results.yaml
file if it does not exist inscripts/artifacts/check-tiup.sh
.Changes walkthrough 📝
check-tiup.sh
Ensure `results.yaml` file exists before modification
scripts/artifacts/check-tiup.sh
results.yaml
file if it does not exist.