chore(tidb): archive log if test not successful

[purelind]

User description

archive log if test not successful, eg test timeout

---

PR Type

enhancement

---

Description

• Modified the post-build action in the ghpr_mysql_test.groovy pipeline script to archive logs if the test is unsuccessful instead of only on failure.

---

Changes walkthrough 📝

	Relevant files
Enhancement	ghpr_mysql_test.groovy Archive logs if test is unsuccessful instead of failure    pipelines/pingcap/tidb/latest/ghpr_mysql_test.groovy Changed the post-build action from failure to unsuccessful for archiving artifacts. +1/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the proposed change is to archive logs if the test is not successful.

Looking at the diff, it appears that the change is modifying a file called ghpr_mysql_test.groovy in the pipelines/pingcap/tidb/latest directory. Specifically, it changes the failure block to unsuccessful block, and archives the artifacts if the test is not successful.

Overall, the change seems reasonable and should not introduce any issues. However, it might be worthwhile to confirm that the change does not interfere with any other parts of the pipeline that may depend on the failure block.

As for suggestions, it might be helpful to add some more context to the pull request description. For example, why was this change deemed necessary and how was it tested? Additionally, it might be helpful to include any relevant issue or ticket numbers related to this change.

[purelind]

test link https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_mysql_test/detail/ghpr_mysql_test/12738/pipeline

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Replace the unsuccessful block with a specific condition like failure to ensure correct behavior Replace the unsuccessful block with a more specific condition such as failure or unstable, depending on the desired behavior when archiving artifacts. The unsuccessful condition is not standard in Jenkins pipelines and may not work as expected. pipelines/pingcap/tidb/latest/ghpr_mysql_test.groovy [121-123] -unsuccessful { +failure { archiveArtifacts(artifacts: 'tidb-test/mysql_test/mysql-test.out*', allowEmptyArchive: true) } Apply this suggestion Suggestion importance[1-10]: 10 Why: The suggestion addresses a critical issue as the unsuccessful condition is not standard in Jenkins pipelines and may lead to unexpected behavior. Replacing it with failure ensures the correct archiving of artifacts.	10

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pipelines/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment