Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-pdf: remove v5.1 and v7.5 as they are archived #3029

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

qiancai
Copy link
Contributor

@qiancai qiancai commented Jul 19, 2024

User description

v5.1 and v7.5 PDFs are archived and will no longer trigger new PDF builds.


PR Type

configuration changes


Description

  • Removed release-5.1 branch from postsubmits configuration in docs-cn-postsubmits.yaml and docs-postsubmits.yaml.
  • Removed release-7.6 branch from postsubmits configuration in docs-cn-postsubmits.yaml and docs-postsubmits.yaml.

Changes walkthrough 📝

Relevant files
Configuration changes
docs-cn-postsubmits.yaml
Update postsubmits configuration for archived branches     

prow-jobs/pingcap/docs/docs-cn-postsubmits.yaml

  • Removed branch release-5.1 from postsubmits
  • Removed branch release-7.6 from postsubmits
  • +2/-2     
    docs-postsubmits.yaml
    Update postsubmits configuration for archived branches     

    prow-jobs/pingcap/docs/docs-postsubmits.yaml

  • Removed branch release-5.1 from postsubmits
  • Removed branch release-7.6 from postsubmits
  • +2/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    ti-chi-bot bot commented Jul 19, 2024

    I have already done a preliminary review for you, and I hope to help you do a better job.

    From the title and description, it seems that this PR is removing v5.1 and v7.5 PDFs as they are now archived. Looking at the diff, it appears that the changes are only in the docs-postsubmits.yaml and docs-cn-postsubmits.yaml files. The changes involve updating the regular expressions for the allowed release branches for PDF builds to exclude v5.1 and v7.5 releases.

    Overall, the changes seem straightforward and appropriate. However, it might be worth checking if there are any other dependencies or components that use the v5.1 and v7.5 releases. If so, this PR might break the build for those components. Additionally, it would be helpful to confirm with the documentation team that these PDFs are no longer needed and can be safely removed.

    As for fixing suggestions, the changes seem appropriate, so there's no need for any additional changes. However, it might be helpful to add a comment explaining why v5.1 and v7.5 releases were removed from the allowed release branches for PDF builds. This would help future contributors to understand the reasoning behind these changes.

    Copy link

    ti-chi-bot bot commented Jul 19, 2024

    Hi @qiancai. Thanks for your PR.

    I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

    Once the patch is verified, the new status will be reflected by the ok-to-test label.

    I understand the commands that are listed here.

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Include release-7.6 in the branch regex to maintain consistency with previous patterns

    Update the regex for release-7 branches to include version release-7.6 as it seems
    to be unintentionally excluded based on the old regex pattern.

    prow-jobs/pingcap/docs/docs-cn-postsubmits.yaml [14]

    -- ^release-7\.[15]$
    +- ^release-7\.[1-6]$
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies that the new regex pattern for release-7 branches excludes version release-7.6, which was included in the old pattern. This update ensures consistency and completeness in the branch matching.

    9

    @wuhuizuo
    Copy link
    Collaborator

    /ok-to-test

    Copy link
    Contributor

    PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.

    @wuhuizuo
    Copy link
    Collaborator

    /lgtm
    /aporove

    Copy link
    Contributor

    PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here.

    Copy link

    ti-chi-bot bot commented Jul 22, 2024

    [APPROVALNOTIFIER] This PR is APPROVED

    This pull-request has been approved by: wuhuizuo

    The full list of commands accepted by this bot can be found here.

    The pull request process is described here

    Needs approval from an approver in each of these files:

    Approvers can indicate their approval by writing /approve in a comment
    Approvers can cancel approval by writing /approve cancel in a comment

    @ti-chi-bot ti-chi-bot bot added the lgtm label Jul 22, 2024
    Copy link

    ti-chi-bot bot commented Jul 22, 2024

    [LGTM Timeline notifier]

    Timeline:

    • 2024-07-22 06:42:42.957821387 +0000 UTC m=+854584.948762857: ☑️ agreed by wuhuizuo.

    @ti-chi-bot ti-chi-bot bot added the approved label Jul 22, 2024
    @ti-chi-bot ti-chi-bot bot merged commit 8bb627b into PingCAP-QE:main Jul 22, 2024
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: Done
    Development

    Successfully merging this pull request may close these issues.

    2 participants