-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs-pdf: remove v5.1 and v7.5 as they are archived #3029
docs-pdf: remove v5.1 and v7.5 as they are archived #3029
Conversation
From the title and description, it seems that this PR is removing v5.1 and v7.5 PDFs as they are now archived. Looking at the diff, it appears that the changes are only in the Overall, the changes seem straightforward and appropriate. However, it might be worth checking if there are any other dependencies or components that use the v5.1 and v7.5 releases. If so, this PR might break the build for those components. Additionally, it would be helpful to confirm with the documentation team that these PDFs are no longer needed and can be safely removed. As for fixing suggestions, the changes seem appropriate, so there's no need for any additional changes. However, it might be helpful to add a comment explaining why v5.1 and v7.5 releases were removed from the allowed release branches for PDF builds. This would help future contributors to understand the reasoning behind these changes. |
Hi @qiancai. Thanks for your PR. I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨
|
/ok-to-test |
PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here. |
/lgtm |
PR-Agent was enabled for this repository, but no eligible user found. Please link your git user with your CodiumAI identity here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
User description
v5.1 and v7.5 PDFs are archived and will no longer trigger new PDF builds.
PR Type
configuration changes
Description
release-5.1
branch from postsubmits configuration indocs-cn-postsubmits.yaml
anddocs-postsubmits.yaml
.release-7.6
branch from postsubmits configuration indocs-cn-postsubmits.yaml
anddocs-postsubmits.yaml
.Changes walkthrough 📝
docs-cn-postsubmits.yaml
Update postsubmits configuration for archived branches
prow-jobs/pingcap/docs/docs-cn-postsubmits.yaml
release-5.1
from postsubmitsrelease-7.6
from postsubmitsdocs-postsubmits.yaml
Update postsubmits configuration for archived branches
prow-jobs/pingcap/docs/docs-postsubmits.yaml
release-5.1
from postsubmitsrelease-7.6
from postsubmits