Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increate timeout for tiflash ut #3078

Merged

Conversation

purelind
Copy link
Collaborator

In some PRs with many changes, the tiflash binary compilation time and test execution time may exceed 60 minutes, so increase the timeout limit here.

Copy link

ti-chi-bot bot commented Aug 13, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request increases the timeout limit for the unit tests in the tiflash pipeline from 60 minutes to 90 minutes to account for cases where the build and test execution time exceeds 60 minutes.

There are no potential problems identified in this pull request.

My suggestion would be to ensure that the timeout limit is increased proportionally to the expected build and test execution time to prevent unnecessarily long timeouts. Also, it would be good to monitor the build and test execution time regularly to ensure that the timeout limit is appropriate.

Copy link

ti-chi-bot bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 58c40fe into PingCAP-QE:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant