-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor pd ut pipelines #3098
feat: refactor pd ut pipelines #3098
Conversation
Based on the diff, it seems like this pull request is adding a new pipeline job for testing Tikv/PD, and also adding a new pod template file for the same job. The changes also include a groovy script for running tests, and updating the latest-presubmits.yaml file to add a new job for unit testing. One potential problem with this pull request is that the new job is marked as optional and not always run, which means that there is a chance that some changes may not be properly tested. It would be better to mark this job as always run and non-optional to ensure that all changes are properly tested. Another issue with the pull request is that the status reporting is disabled during the test period. This can make it difficult to track the progress of the tests and identify any issues that may arise. To fix these issues, the pull request should be updated to mark the new job as always run and non-optional. Additionally, the status reporting should be enabled during the test period to make it easier to track the progress of the tests. |
Based on the pull request title and description, it seems that the changes are related to refactoring the pipelines for unit testing in the Looking at the diff, it seems that the changes are adding a new Jenkins pipeline for the unit test, adding a new pod for the pipeline, and some modifications in the existing Jenkins pipeline for running the unit tests. There are a couple of potential issues that need to be addressed:
Here are some suggestions for fixing these issues:
Once these issues are addressed, it should be safe to merge this pull request. |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/hold |
/unhold |
Refactor pd ut pipelines, Status reporting is disabled during the test period.