Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor pd ut pipelines #3098

Merged

Conversation

purelind
Copy link
Collaborator

Refactor pd ut pipelines, Status reporting is disabled during the test period.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo August 30, 2024 08:06
Copy link

ti-chi-bot bot commented Aug 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff, it seems like this pull request is adding a new pipeline job for testing Tikv/PD, and also adding a new pod template file for the same job. The changes also include a groovy script for running tests, and updating the latest-presubmits.yaml file to add a new job for unit testing.

One potential problem with this pull request is that the new job is marked as optional and not always run, which means that there is a chance that some changes may not be properly tested. It would be better to mark this job as always run and non-optional to ensure that all changes are properly tested.

Another issue with the pull request is that the status reporting is disabled during the test period. This can make it difficult to track the progress of the tests and identify any issues that may arise.

To fix these issues, the pull request should be updated to mark the new job as always run and non-optional. Additionally, the status reporting should be enabled during the test period to make it easier to track the progress of the tests.

Copy link

ti-chi-bot bot commented Aug 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to refactoring the pipelines for unit testing in the tikv/pd repository. The status reporting during the test period is disabled in this pull request.

Looking at the diff, it seems that the changes are adding a new Jenkins pipeline for the unit test, adding a new pod for the pipeline, and some modifications in the existing Jenkins pipeline for running the unit tests.

There are a couple of potential issues that need to be addressed:

  1. There are commented out sections of code in the modified pipeline. These should be either removed or uncommented if they are needed.

  2. It is not clear why the always_run and optional flags are set to false for the new pipeline. These should be reviewed and updated if needed.

  3. There is a skip_report flag set to true for the new pipeline. This should be reviewed and updated if needed.

  4. The cloneOptions in the Jenkinsfile should not have shallow set to true because it may cause issues during the clone process.

Here are some suggestions for fixing these issues:

  1. Remove or uncomment any code that is not needed.

  2. Review the always_run and optional flags for the new pipeline and update them if needed.

  3. Review the skip_report flag for the new pipeline and update it if needed.

  4. Remove shallow(true) from the cloneOptions in the Jenkinsfile.

Once these issues are addressed, it should be safe to merge this pull request.

@purelind
Copy link
Collaborator Author

/hold

Copy link

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@purelind
Copy link
Collaborator Author

/unhold

@purelind
Copy link
Collaborator Author

/hold

@purelind
Copy link
Collaborator Author

purelind commented Sep 9, 2024

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 8102dcc into PingCAP-QE:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant