Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest-presubmits.yaml #3101

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Update latest-presubmits.yaml #3101

merged 1 commit into from
Sep 3, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 3, 2024

No description provided.

Copy link

ti-chi-bot bot commented Sep 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the diff, it looks like the pull request updates the latest-presubmits.yaml file for the tidb-engine-ext project. The changes include adding a new environment variable CARGO_NET_GIT_FETCH_WITH_CLI with a value of "true".

One potential problem with this change is that it's not clear why this environment variable is needed and what impact it will have on the build and test process. It's also not clear if this change has been tested thoroughly.

To address these concerns, I would suggest adding a comment to the pull request asking for more information about the purpose of the CARGO_NET_GIT_FETCH_WITH_CLI environment variable and requesting more details about the testing that has been done to ensure that this change doesn't introduce any new issues.

If the information provided is satisfactory, then the pull request can be approved and merged.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 3, 2024
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 3, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Sep 3, 2024
Copy link
Contributor

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Sep 3, 2024

@CalvinNeo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo wuhuizuo added the lgtm label Sep 3, 2024
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 0b1a6da into main Sep 3, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wuhuizuo-patch-1 branch September 3, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants