Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib): increase refreash time for lib cache #3149

Conversation

purelind
Copy link
Collaborator

Increase refreash time for lib cache from 1 hour to 1 day.

Copy link

ti-chi-bot bot commented Sep 29, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, it seems that the refresh time for lib cache is being increased from 1 hour to 1 day. This change is reflected in the aa_folder.groovy file on line 24.

There don't seem to be any potential problems with this change, as increasing the refresh time for the lib cache can improve performance and reduce resource consumption. However, it's worth keeping in mind that if the library is updated frequently, this change may result in users not getting the latest updates until 1 day after they are released.

As a suggestion, it might be helpful to add a comment in the pull request explaining why the refresh time is being increased and how it will benefit the system. Additionally, if there are any potential downsides to this change, it would be useful to mention them in the pull request as well.

Overall, this seems like a reasonable change that can improve system performance, but it's always important to carefully consider the potential impact of any changes before implementing them.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 29, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the following key changes have been made:

  • The refresh time for lib cache has been increased from 1 hour to 1 day.
  • A includedVersionsStr parameter has been added to allow caching of specific versions.

There do not seem to be any potential problems with the changes made in this pull request.

Suggestions for fixing:

  • None, the changes seem appropriate and do not introduce any issues. However, it would be useful to add more information to the pull request description, such as the reason behind the change.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 29, 2024
Copy link

ti-chi-bot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-29 07:07:21.502539525 +0000 UTC m=+165796.922752531: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit f6831d0 into PingCAP-QE:main Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants