Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Permission for go1.23 #3155

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

hawkingrei
Copy link
Contributor

No description provided.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link

ti-chi-bot bot commented Oct 9, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and diff, it seems that the PR is fixing a permission issue for the go1.23 image in several files in the pipelines and jenkins directories. The change is simply updating the image tag from go12320241008 to go12320241009.

There are no potential problems that can be identified from the diff.

The fix looks good to me. I suggest that the author of the PR should provide a brief description of the problem that this PR is addressing in the PR description to help other contributors understand the context of this change.

Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 9, 2024
Copy link

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-09 02:17:39.435029006 +0000 UTC m=+1012414.855242018: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1a7604a into PingCAP-QE:main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants