Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase resource for merged ut to increase stability #3158

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Oct 9, 2024

increase resource for merged ut to increase stability

Copy link

ti-chi-bot bot commented Oct 9, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary:
The pull request increases the resources for merged unit tests to increase stability. The changes are made in the pod-merged_unit_test.yaml file, where the CPU and memory limits are increased for the golang container. A new volume mount is added for the bazel repository cache.

Potential Problems:

  • The new resource limits are significantly higher than before. This may cause resource exhaustion and impact other pods running on the same node.
  • The addition of a new volume mount for bazel repository cache may impact the performance of the pod.

Fixing Suggestions:

  • Monitor the resource usage of the pod after the changes are made to ensure that it doesn't cause resource exhaustion.
  • Consider using a horizontal pod autoscaler to adjust the resources based on the workload.
  • Use a dedicated node pool for running the high resource pods.
  • Test the impact of the new volume mount on the pod's performance before deploying to production.

Copy link

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b350182 into PingCAP-QE:main Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant