Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support build for v8.4 #3165

Merged

Conversation

purelind
Copy link
Collaborator

support build for v8.4

Copy link

ti-chi-bot bot commented Oct 10, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request adds support for building version 8.4 and changes the release tags to reflect this new version. However, there are a few potential issues to note:

  • The description is very brief and doesn't provide much context about the changes.
  • There are no tests included in this pull request, so it's unclear if the changes will work as expected.
  • It's not clear if the changes have been tested locally or in a staging environment before being pushed to the main branch.

To improve this pull request, I suggest the following:

  • Add more detail to the pull request description to explain why these changes are being made and what impact they will have.
  • Add tests for the new version to ensure that everything is working as expected.
  • Test the changes locally and in a staging environment before merging to the main branch. This will help catch any issues before they are pushed to production.

Overall, this pull request seems like a small and straightforward change, as long as it's thoroughly tested and the changes work as expected.

Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S label Oct 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 228ad2c into PingCAP-QE:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant