Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tiflash): start use rocky8 as base image #3186

Merged

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Oct 28, 2024

CentOS 7 has reached the end of its life cycle. Starting from version 8.4, we began using Rocky Linux 8 as the base image.

Relate to pingcap/tiflash#9556

Copy link

ti-chi-bot bot commented Oct 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added size/S and removed size/M labels Oct 29, 2024
@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Oct 29, 2024
@purelind purelind marked this pull request as ready for review October 30, 2024 02:23
@purelind
Copy link
Collaborator Author

/hold

Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

ti-chi-bot bot commented Oct 30, 2024

@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@purelind
Copy link
Collaborator Author

/retest

@purelind
Copy link
Collaborator Author

/unhold

@ti-chi-bot ti-chi-bot bot merged commit 2718a3a into PingCAP-QE:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants