Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(script/flow/rc): fix flow check script #3191

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

wuhuizuo
Copy link
Collaborator

  • skip check for tidb-binlog since v8.4.0.
  • fix the shell sharbang.

Signed-off-by: wuhuizuo wuhuizuo@126.com

- skip check for tidb-binlog since v8.4.0.
- fix the shell sharbang.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind October 29, 2024 11:15
Copy link

ti-chi-bot bot commented Oct 29, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that this pull request fixed the flow check script by skipping the check for tidb-binlog since v8.4.0 and fixing the shell sharbang. The changes consist of updating the sharbang in two files and adding a check to skip tidb-binlog if the version is greater than or equal to v8.4.0.

Overall, the changes look good and do not introduce any major problems. However, there are a few suggestions for improvement:

  • It would be better to provide more information in the pull request description about why the changes were made. This can help reviewers understand the context of the changes and whether they are necessary.
  • The pull request could benefit from some additional testing to ensure that the changes do not introduce any new issues. The author could run the flow check and other relevant tests to ensure that everything works as expected.
  • The version check for tidb-binlog could be improved by checking the actual version number instead of just the string representation. This can help prevent issues if the versioning scheme changes in the future.

Overall, the changes look good and can be merged after addressing the suggestions above.

@ti-chi-bot ti-chi-bot bot added the size/S label Oct 29, 2024
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 29, 2024
Copy link

ti-chi-bot bot commented Oct 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-29 11:39:20.130086398 +0000 UTC m=+349872.969241939: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 89a5f74 into main Oct 29, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the fix/update-flow-check-script branch October 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants