Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cd): correct fetch version from tiflow branch #3200

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Nov 1, 2024

No description provided.

Signed-off-by: purelind <purelind@gmail.com>
Copy link

ti-chi-bot bot commented Nov 1, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the given information, it seems that the pull request is fixing an issue related to the Continuous Deployment (CD) pipeline. The change is made in the release-all-images-by-branch.groovy file, where the fetch_hash function is being utilized to fetch the hash of different components. In the original code, the hash for ticdc was being fetched, but in this pull request, it is being changed to tiflow.

As for potential problems, without the context of the entire codebase or the CD pipeline, it is difficult to say for sure if this change will cause any issues. It is possible that the change could break some part of the pipeline that is dependent on the ticdc hash, but it is also possible that this change is necessary and will not cause any issues.

As for fixing suggestions, it would be beneficial to have more information about why this change is being made. If there is a specific reason for switching from ticdc to tiflow, it would be helpful to document it in the pull request description. Additionally, it would be good to test the changes thoroughly and ensure that the CD pipeline is still functioning as expected after the change is made.

Copy link

ti-chi-bot bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit bdbb9b3 into PingCAP-QE:main Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant