Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prow approve plugin issue kubernetes/test-infra#7690 #621

Closed
wuhuizuo opened this issue Jun 27, 2023 · 1 comment
Closed

Fix prow approve plugin issue kubernetes/test-infra#7690 #621

wuhuizuo opened this issue Jun 27, 2023 · 1 comment

Comments

@wuhuizuo
Copy link
Collaborator

No description provided.

@wuhuizuo wuhuizuo converted this from a draft issue Jun 27, 2023
@wuhuizuo
Copy link
Collaborator Author

code fixed in: ti-community-infra/test-infra#32

@wuhuizuo wuhuizuo moved this from 🆕 New to 🏗 In progress in EE - CI/CD system Jun 27, 2023
@wuhuizuo wuhuizuo mentioned this issue Jun 29, 2023
Merged
wuhuizuo added a commit to ti-community-infra/test-infra that referenced this issue Jun 29, 2023
@wuhuizuo
fix(prow/plugins/approve): support get approvers when used full config (
a95a424 
#32)

## What

Fixed: kubernetes#7690

Ref:
- PingCAP-QE/ee-ops#621

## How

- Make it be fixed without massive refactoring, and not change the
behavior and approve notifies.

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in EE - CI/CD system Jun 29, 2023
wuhuizuo added a commit to ti-community-infra/test-infra that referenced this issue Sep 11, 2023
@wuhuizuo
fix(prow/plugins/approve): support get approvers when used full config (
a46744a 
#32)

Fixed: kubernetes#7690

Ref:
- PingCAP-QE/ee-ops#621

- Make it be fixed without massive refactoring, and not change the
behavior and approve notifies.

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
EE - CI/CD system
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wuhuizuo