Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins-beta): upgrade chart #1196

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 2, 2024

use official chart

Signed-off-by: wuhuizuo wuhuizuo@126.com

use official chart

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Key changes:

  • Upgraded the Jenkins chart to version 5.0.13.
  • Changed the sourceRef kind from GitRepository to HelmRepository.
  • Updated the Jenkins controller image to use a different registry, repository, and tag.

Potential problems:

  • The change to the sourceRef kind from GitRepository to HelmRepository may cause issues with the existing GitRepository source.

Fixing suggestions:

  • Check if the existing GitRepository source is still required and modify the source configuration if needed.
  • Verify if the new Jenkins chart version is compatible with the existing setup and test it thoroughly.
  • Ensure that the new Jenkins controller image is available and has been tested in the environment before deploying it to production.

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/L labels Aug 2, 2024
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Aug 2, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3772ff7 into main Aug 2, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/upgrade-beta-jenkins branch August 2, 2024 14:38
wuhuizuo added a commit that referenced this pull request Aug 2, 2024
use official chart

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
wuhuizuo added a commit that referenced this pull request Aug 2, 2024
use official chart

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
wuhuizuo added a commit that referenced this pull request Aug 2, 2024
use official chart

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
wuhuizuo added a commit that referenced this pull request Aug 2, 2024
use official chart

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant