Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clean-code-cache): correct read env from secret in cronjob #1379

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

purelind
Copy link
Contributor

correct read env from secret in cronjob

Signed-off-by: purelind <purelind@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, it looks like the changes made were to correct the way the environment variable is read from the secret in the cronjob. The change made was to replace the environment variable reference ${CI_MONITOR_FEISHU_WEBHOOK_URL} with $(CI_MONITOR_FEISHU_WEBHOOK_URL).

There are no potential problems with this change. However, it is a good practice to use double quotes instead of single quotes when using environment variables in command arguments. This ensures that the variable is properly expanded before being executed.

Therefore, I suggest modifying the line to use double quotes as shown below:

-                - --feishu-webhook=$(CI_MONITOR_FEISHU_WEBHOOK_URL)
+                - --feishu-webhook="${CI_MONITOR_FEISHU_WEBHOOK_URL}"

Other than that, the change looks good and can be merged.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo December 17, 2024 10:01
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XS labels Dec 17, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 0be4a6e into PingCAP-QE:main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant