Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs): use aws-cli to upload to qiniu #1390

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

wuhuizuo
Copy link
Collaborator

prepare for compatible with future object storage providers.

Signed-off-by: wuhuizuo wuhuizuo@126.com

@ti-chi-bot ti-chi-bot bot requested a review from purelind December 24, 2024 08:55
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/L labels Dec 24, 2024
@wuhuizuo wuhuizuo force-pushed the feature/unify-bucket-upload-use-aws-cli branch from 6eab8c6 to 9fa4e78 Compare January 14, 2025 14:32
…cd/utils/release tag to `v2024.10.8-71-gf13e219`

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
prepare for compatible with future object storage providers.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…w bucket

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the feature/unify-bucket-upload-use-aws-cli branch from 9fa4e78 to e9c2ed4 Compare January 16, 2025 12:56
@wuhuizuo wuhuizuo marked this pull request as ready for review January 16, 2025 12:56
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

The Pull Request (PR) is titled "feat(apps/prod/tekton/configs): use aws-cli to upload to qiniu". It aims to update the configuration files in the Tekton CI/CD pipeline to use AWS CLI for uploading files to the Qiniu cloud storage.

Key changes in the PR:

  1. The Qiniu credentials parameter (qiniu-creds-secret-name) is removed and replaced with AWS credentials (aws-secrets-tencent).
  2. The AWS secrets are added as optional workspaces in multiple tasks within the pipeline.
  3. The build image tag has been updated in multiple files from v20240325-60-gb6f8928 to v2024.10.8-71-gf13e219.
  4. The code for uploading files to Qiniu is replaced with AWS CLI commands for uploading files to S3.
  5. The indentation of some lines of code has been adjusted to maintain consistency.

Potential problems:

  1. No information is provided whether the AWS CLI is installed or not in the environment where this pipeline will run.
  2. The AWS secrets and bucket name are expected to be found in the workspace, but there is no check or handling if they are not provided or incorrect.
  3. Directly changing the storage provider from Qiniu to S3 might lead to potential compatibility issues, like different file paths, API behaviors, etc.
  4. The PR doesn't include any tests to verify whether the changes work as expected.

Suggestions to fix:

  1. Make sure the AWS CLI is installed in the environment where this pipeline runs.
  2. Add error handling for cases where the AWS secrets or bucket name are not provided or incorrect.
  3. Conduct a thorough analysis to understand the impact of changing the storage provider to avoid any potential issues.
  4. Include tests in the PR to verify that the changes work as expected.
  5. It would be better to provide more details in the PR description about why this change needs to be made, how it was tested, and any potential impact this change may cause to existing systems or processes.

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 16, 2025
@ti-chi-bot ti-chi-bot bot merged commit dfd87cb into main Jan 16, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/unify-bucket-upload-use-aws-cli branch January 16, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant