feat(pingcap/tidb-operator): delivery v2.x.y images to external registries #1410
Conversation
…tries Signed-off-by: wuhuizuo <wuhuizuo@126.com>
From the pull request title and diff, it seems that the changes are related to delivering v2.x.y images to external registries. The changes in the diff appear to be updating a YAML configuration file for image-push-on-harbor to include a check for the repo_full_name and tag of the pushed image, and then allowing delivery of the image if it matches the specified criteria. One potential problem with this change is that it may be too specific to the current use case of the pingcap/tidb-operator repository. If other repositories need to deliver images to external registries, they may not match the specified criteria and would not be allowed to deliver their images. Additionally, if the criteria for matching the repo_full_name and tag need to be updated in the future, it may require further changes to the configuration file. One suggestion for fixing this would be to make the criteria for matching the repo_full_name and tag more generic and configurable, so that it can be easily updated in the future if needed. Another suggestion would be to add comments to the configuration file explaining the purpose of this change and the criteria for matching the repo_full_name and tag, to make it easier for future maintainers to understand the reasoning behind this change. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc, wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
No description provided.