Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs/triggers): parse profile param from cloud event extension #1411

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

wuhuizuo
Copy link
Collaborator

This pull request includes changes to the Tekton trigger configurations to improve the handling of the profile parameter. The main updates involve reading the profile parameter from the header or defaulting to 'release' and ensuring that the profile parameter is correctly passed to the bindings.

Key changes:

…loud event extension

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind January 24, 2025 02:48
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Jan 24, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:
This pull request makes changes to the Tekton trigger configurations to improve the handling of the profile parameter. The changes involve reading the profile parameter from the header or defaulting to 'release' and ensuring that the profile parameter is correctly passed to the bindings.

Potential problems:
It is not clear from the pull request description whether the changes have been tested or not. It is important to ensure that changes have been tested before merging into the main branch.

Fixing suggestions:
To ensure that changes have been tested, the reviewer should ask the pull request author to describe the testing process or to provide evidence of successful testing. The reviewer could also suggest that the author adds testing instructions to the pull request description. Additionally, the reviewer should check that the changes comply with the project's coding standards and best practices.

@ti-chi-bot ti-chi-bot bot added the size/S label Jan 24, 2025
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9ff7307 into main Jan 24, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/support-devbuild-profile branch January 24, 2025 02:54
wuhuizuo added a commit that referenced this pull request Jan 24, 2025
…loud event extension (#1411)

This pull request includes changes to the Tekton trigger configurations
to improve the handling of the `profile` parameter. The main updates
involve reading the `profile` parameter from the header or defaulting to
'release' and ensuring that the `profile` parameter is correctly passed
to the bindings.

Key changes:

*
[`apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-branch-push.yaml`](diffhunk://#diff-568be39468441f09f11d91d4c71d77c96952fb478d3695735af6b02f24cb8969L64-R77):
Updated the `custom-params` to include the `profile` parameter from the
header or default to 'release', and modified the binding to use
`$(extensions.custom-params.profile)` for the `profile` parameter.
*
[`apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-pr.yaml`](diffhunk://#diff-16116bc799a164aec2da92871c9b9f6e55fc88587d954afb5d13c261f014fefcL64-R71):
Similar update to include the `profile` parameter in `custom-params` and
use `$(extensions.custom-params.profile)` in the binding.
*
[`apps/prod/tekton/configs/triggers/triggers/_/fake-github/fake-github-tag-create.yaml`](diffhunk://#diff-91cd5bc58ced2d97dfd4052e5009edbe7fffbe44f7427f2bb0a0d084636dc615L66-R73):
Included the `profile` parameter in `custom-params` and updated the
binding to use `$(extensions.custom-params.profile)`.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant