Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps/prod/tekton/configs/triggers/templates): increase size for source workspace #772

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat(apps/prod/tekton/configs/triggers/templates): increase size for source workspace #772

merged 1 commit into from
Nov 10, 2023

Conversation

wuhuizuo
Copy link
Collaborator

  • tidb: 10GB
  • pd: 2GB
  • tikv: 10GB
  • tiflow: 10GB
  • tiflash: 10GB

Signed-off-by: wuhuizuo wuhuizuo@126.com

@wuhuizuo
feat(apps/prod/tekton/configs/triggers/templates): increase size for …
b864ac0 
…`source` workspace

- tidb: 10GB
- pd: 2GB
- tikv: 10GB
- tiflow: 10GB
- tiflash: 10GB

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind November 10, 2023 08:45
@ti-chi-bot ti-chi-bot bot added the area/apps label Nov 10, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request increases the size of the storage requests for various applications (tidb, pd, tikv, tiflow, and tiflash) in the push.yaml files. The storage requests are increased from 1Gi to 10Gi for most applications, except for pd, which is increased from 1Gi to 2Gi.

There do not seem to be any potential problems with this pull request, as it is a straightforward change that only involves increasing the size of storage requests. However, it would be helpful to add more information in the pull request description, such as why the storage requests are being increased and what impact this will have on the application.

A suggestion for fixing this pull request would be to add more detail to the pull request description. Additionally, it may be helpful to include any relevant testing or documentation changes that were made to accommodate the increased storage requests.

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/S labels Nov 10, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 10, 2023
@ti-chi-bot ti-chi-bot bot merged commit dd84592 into main Nov 10, 2023
@ti-chi-bot ti-chi-bot bot deleted the fix/increase-git-clone-workspace-size branch November 10, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayl1e jayl1e Awaiting requested review from jayl1e

@purelind purelind Awaiting requested review from purelind

Assignees
No one assigned
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wuhuizuo