Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs): fix git clone steps #774

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

wuhuizuo
Copy link
Collaborator

  • also disable the passed triggers for repo: pd, tidb, tiflow

- also disable the passed triggers for repo: pd, tidb, tiflow

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind November 13, 2023 08:03
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request updates the apps/prod/tekton/configs directory. Specifically, it adds a new git-credentials workspace to the push-build-package.yaml pipeline, updates the git-clone.yaml task to add new parameters, updates the git-clone.yaml task to version 0.9, and updates push.yaml files to disable triggers for pd, tidb, and tiflow repositories.

Potential problems:

  • It is not clear why the triggers for pd, tidb, and tiflow repositories are being disabled.
  • The git-clone.yaml task update to version 0.9 may cause issues with compatibility with other tasks in the pipeline.
  • The addition of a new parameter crtFileName to git-clone.yaml is not well documented, it may need better documentation or naming.
  • It is not clear why the GIT_SSH_COMMAND environment variable is set in the git-clone.yaml task.

Fixing suggestions:

  • More information should be provided about why the triggers for pd, tidb, and tiflow repositories are being disabled. If there is a good reason for this, it should be documented.
  • The git-clone.yaml task update to version 0.9 should be tested thoroughly to ensure there are no compatibility issues with other tasks in the pipeline.
  • The crtFileName parameter in git-clone.yaml should be documented more clearly, and possibly renamed to better reflect its purpose.
  • The reason for setting the GIT_SSH_COMMAND environment variable in the git-clone.yaml task should be documented, or this line should be removed if it is not necessary.

@ti-chi-bot ti-chi-bot bot added the size/M label Nov 13, 2023
@wuhuizuo
Copy link
Collaborator Author

I have already done a preliminary review for you, and I hope to help you do a better job.
This pull request updates the apps/prod/tekton/configs directory. Specifically, it adds a new git-credentials workspace to the push-build-package.yaml pipeline, updates the git-clone.yaml task to add new parameters, updates the git-clone.yaml task to version 0.9, and updates push.yaml files to disable triggers for pd, tidb, and tiflow repositories.

Potential problems:

  • It is not clear why the triggers for pd, tidb, and tiflow repositories are being disabled.
  • The git-clone.yaml task update to version 0.9 may cause issues with compatibility with other tasks in the pipeline.
  • The addition of a new parameter crtFileName to git-clone.yaml is not well documented, it may need better documentation or naming.
  • It is not clear why the GIT_SSH_COMMAND environment variable is set in the git-clone.yaml task.

Fixing suggestions:

  • More information should be provided about why the triggers for pd, tidb, and tiflow repositories are being disabled. If there is a good reason for this, it should be documented.
  • The git-clone.yaml task update to version 0.9 should be tested thoroughly to ensure there are no compatibility issues with other tasks in the pipeline.
  • The crtFileName parameter in git-clone.yaml should be documented more clearly, and possibly renamed to better reflect its purpose.
  • The reason for setting the GIT_SSH_COMMAND environment variable in the git-clone.yaml task should be documented, or this line should be removed if it is not necessary.

They are passed: pd, tiflow, tidb

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 424f836 into main Nov 13, 2023
@ti-chi-bot ti-chi-bot bot deleted the fix/tekton-git-clone-step branch November 13, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant