Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs): fix builder images for tikv and tiflash building #776

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

wuhuizuo
Copy link
Collaborator

The new builder images is WIP, now we use the old ones.

…h building

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind November 14, 2023 04:18
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Nov 14, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

This pull request aims to fix the builder images for tikv and tiflash building. The changes include updating the builder images in the pipeline files push-build-package.yaml, push.yaml, and push.yaml.

There are no potential problems with this pull request as it is a straightforward change.

However, the pull request description mentions that "The new builder images is WIP, now we use the old ones." It is unclear what the "new builder images" refer to and why they are not used. It would be helpful to provide more context and information about this in the pull request description.

Additionally, it is worth considering adding more information to the description field for the builder-image parameter in the push-build-package.yaml file to make it more self-explanatory.

Suggestions

  • Provide more context and information about the "new builder images" in the pull request description.
  • Consider adding more information to the description field for the builder-image parameter in the push-build-package.yaml file.
  • If there are any specific issues related to the new builder images, they should be mentioned and addressed.

@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot ti-chi-bot bot added the size/S label Nov 14, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit 386f919 into main Nov 14, 2023
@ti-chi-bot ti-chi-bot bot deleted the feature/fix-builder-images-for-tiflash-and-tikv branch November 14, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant