Fix build deprecation warnings in using pyproject.toml and setuptool #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleifnf
changed the title
justinGilmer
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
pip install --verbosefor the project, we get some deprecation warnings for the build "configuration would be ignored/result in error due topyproject.toml[...] By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported."To stick to the PEP standards and the setuptools, this PR attemps to fix that.
Note: we can leave an minimal setup.py if we're using project.toml, see the docs here.