Skip to content

Fix Redundant Tag Sending #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

Fix Redundant Tag Sending #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97d0435
Fixes redundant tag sending and updates the test to be correct with t…
SiverJohn Sep 12, 2025
ebb51ae
Update the mocked test to properly mock the expected property version.
justinGilmer Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion btrdb/stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ def _update_tags_collection(self, tags, collection):
"""
:meta private:
"""
tags = self.tags() if tags is None else tags
tags = {} if tags is None else tags
collection = self.collection if collection is None else collection
if collection is None:
raise BTRDBValueError(
Expand Down
5 changes: 2 additions & 3 deletions tests/btrdb/test_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,15 +272,14 @@ def test_update_collection(self):
endpoint = Mock(Endpoint)
endpoint.streamInfo = Mock(return_value=("koala", 42, {}, {}, None))
endpoint.info = Mock(return_value={"majorVersion": 5, "minorVersion": 30})
stream = Stream(btrdb=BTrDB(endpoint), uuid=uu)
stream = Stream(btrdb=BTrDB(endpoint), uuid=uu, property_version=42)

collection = "giraffe"

stream.update(collection=collection)
stream._btrdb.ep.setStreamTags.assert_called_once_with(
uu=uu, expected=42, tags=stream.tags(), collection=collection
uu=uu, expected=42, tags={}, collection=collection
)
stream._btrdb.ep.setStreamAnnotations.assert_not_called()

def test_update_annotations(self):
"""
Expand Down
Loading