Skip to content

Ana06/get-changed-files v2.3.0 Considers renamed modified files as modified #13043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danhsiung merged 2 commits into from
Jul 30, 2024
Merged

Ana06/get-changed-files v2.3.0 Considers renamed modified files as modified #13043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d193b1
Ana06/get-changed-files v2.3.0 Adds added_modified_renamed that inclu…
danhsiung Jul 30, 2024
69f0ccd
slight modification in that we should ignore renamed files that are not
danhsiung Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/publish-components.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ jobs:
PUBLISHED=""
ERRORS=""
SKIPPED=""
mapfile -d ',' -t added_modified_renamed_files < <(printf '%s,%s' '${{ steps.files.outputs.added_modified }}' '${{ steps.files.outputs.renamed }}')
for added_modified_file in "${added_modified_renamed_files[@]}"; do
# Ana06/get-changed-files@v2.3.0 treats renamed files that are modified as modified. We shouldn't be renaming files without modification.
mapfile -d ',' -t added_modified_files < <(printf '%s' '${{ steps.files.outputs.added_modified }}')
for added_modified_file in "${added_modified_files[@]}"; do
# starts with components, ends with .*js (e.g. .js and .mjs) and not app.js,
# doesn't end with /common*.*js, and doesn't follow */common/
if [[ $added_modified_file == components/* ]] && [[ $added_modified_file == *.*js ]] && [[ $added_modified_file != *.app.*js ]] \
Expand Down Expand Up @@ -178,10 +179,11 @@ jobs:
PUBLISHED=""
ERRORS=""
SKIPPED=""
mapfile -d ',' -t added_modified_renamed_files < <(printf '%s,%s' '${{ steps.files.outputs.added_modified }}' '${{ steps.files.outputs.renamed }}')
# Ana06/get-changed-files@v2.3.0 treats renamed files that are modified as modified. We shouldn't be renaming files without modification.
mapfile -d ',' -t added_modified_files < <(printf '%s' '${{ steps.files.outputs.added_modified }}')
# included in the components dir, ends with .ts and not app.ts,
# doesn't end with /common*.ts, and doesn't follow */common/
for added_modified_file in "${added_modified_renamed_files[@]}";
for added_modified_file in "${added_modified_files[@]}";
do
echo "Checking if $added_modified_file is a publishable ts file"
if [[ $added_modified_file == components/* ]] && [[ $added_modified_file == *.ts ]] && [[ $added_modified_file != *.app.ts ]] \
Expand Down