[ACTION] Clubhouse.io (now Shortcut)

[sergioeliot2039]

PR for Clubhouse actions
Create Story
Search Stories

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

pipedream-docs-redirect-do-not-edit – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs-redirect-do-not-edit/9YrZKUkvSS3shH2tFVznm6grohKg
✅ Preview: https://pipedream-docs-redirect-do-not-edit-git-for-41f22e-pipedreamers.vercel.app

pipedream-docs – ./docs

🔍 Inspect: https://vercel.com/pipedreamers/pipedream-docs/CN7PVurxgJzoQBvy6rTY1sMV7L4M
✅ Preview: https://pipedream-docs-git-fork-sergioeliot2039-clu-db59d8-pipedreamers.vercel.app

[compwright]

@sergioeliot2039 thank you for this! Per the Guidelines, please make the following changes:

• Rebase off master
• Fix all eslint issues
• Refactor all props that are used more than once into the app file
• Refactor all API access code to use the clubhouse-lib where possible, unless there is a good reason not to do so (please explain in detail wherever this is the case)
• Add options() methods wherever possible to all ID props to populate options (epicId, groupId, etc)

[sergioeliot2039]

@compwright when i started developing components, the criteria to use a library was:

1. be an official library
2. have thousands of weekly downloads
3. be mantained oftenly.

in the case for if you check stats in npm for clubhouse-lib the lib is official and has ~3k weekly download, but last update was over 5 months ago. that's why I didn't use it. another parameter I use is that usually PD team will use the library in Legacy actions' "Run node.js code with CLubhouse", and they are using the API directly.

[dylburger]

@sergioeliot2039 I think we can be a little loose on #2 and #3 if it's an official library. It looks like the maintainers are pushing new releases every so often. It's probably the case that the API hasn't changed in the last few months. This is a tough call but in this specific case I'd use the npm package. Clubhouse isn't the largest app, and that's part of the reason why I think the number of downloads is low.

[sergioeliot2039]

@jcortes this ready for a new review.

[jcortes]

Just a couple of suggestions and you are good to go! Thanks for making those changes!

[jcortes]

Sorry I forgot my last comment about returning the statusCode not as an array but as a single value.

[jcortes]

It looks good to me!

Old review

[dannyroosevelt]

The Create Story action functionally works, but it returns the below console.log() statement:
CIRCULAR_RETURN_VALUEReturn value contains [Circular] reference(s) that were filtered out.

[dannyroosevelt]

@sergioeliot2039 I pushed a few changes and created a new PR from the pipedream repo, so it's in sync w/ master

[vercel]

@sergioeliot2039 is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

[sergioeliot2039]

this has been corrected. i have move its card to ready for qa. but let me know if it should be in ready for review instead.

[dannyroosevelt]

Looks good, @sergioeliot2039 ! I see there are some Lint errors you'll need to address before merging.

[sergioeliot2039]

Great, @dylburger .
I fixed lint errors. Merging blocked because of Vercel - pipedream-docs.
Your turn (I guess)!