Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Google calendar - Upcoming Event Alert does not emit new event #14134

Conversation

jcortes
Copy link
Collaborator

@jcortes jcortes commented Sep 27, 2024

WHY

Resolves #14126

Summary by CodeRabbit

  • New Features

    • Updated the Google Calendar integration package to version 0.5.6.
    • Enhanced the upcoming-event-alert functionality with a new parameter to control data retrieval.
  • Bug Fixes

    • Incremented version of the upcoming-event-alert module to 0.0.9, indicating improvements or fixes.
  • Chores

    • Updated the spellcheck GitHub Actions workflow to use version 0.42.0.

@jcortes jcortes added the bug Something isn't working label Sep 27, 2024
@jcortes jcortes self-assigned this Sep 27, 2024
Copy link

vercel bot commented Sep 27, 2024

@jcortes is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Sep 27, 2024 9:55pm

Copy link
Contributor

coderabbitai bot commented Sep 27, 2024

Walkthrough

The pull request introduces updates to the Google Calendar components, specifically incrementing the version numbers of the @pipedream/google_calendar package and the upcoming-event-alert.mjs file. Additionally, a new parameter, returnOnlyData, has been added to the getCalendarEvents method, which may alter how calendar events are processed. These changes aim to address issues related to event emission.

Changes

File Change Summary
components/google_calendar/package.json Updated version from 0.5.5 to 0.5.6.
components/google_calendar/sources/upcoming-event-alert/upcoming-event-alert.mjs Updated version from 0.0.8 to 0.0.9 and added returnOnlyData parameter set to false in getCalendarEvents method.
.github/workflows/pull-request-checks.yaml Updated action version from 0.40.0 to 0.42.0 in the GitHub Actions workflow.

Assessment against linked issues

Objective Addressed Explanation
Upcoming Event Alert should emit new events (Issue #14126) It is unclear if the changes fully resolve the issue. The new parameter may affect event emission but does not directly confirm it.

Possibly related PRs

Suggested reviewers

  • lcaresia

Poem

🐇 In the garden where events bloom,
A tweak to alert, dispelling gloom.
With a hop and a skip, new data to find,
A calendar dance, with joy intertwined!
So let the events now brightly shine,
For every moment, we’ll make it divine! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 40b4605 and ccb32d9.

📒 Files selected for processing (1)
  • .github/workflows/pull-request-checks.yaml (1 hunks)
🔇 Additional comments (1)
.github/workflows/pull-request-checks.yaml (1)

38-38: Clarify the reason for updating the spellcheck action version.

I noticed that the version of rojopolis/spellcheck-github-actions has been updated from 0.40.0 to 0.42.0. While keeping actions up-to-date is generally a good practice, this change doesn't seem directly related to the PR's main objective of fixing the Google Calendar - Upcoming Event Alert issue.

Could you please clarify the reason for this update? Additionally, it would be prudent to verify that this new version doesn't introduce any breaking changes that might affect our CI process.

To ensure the new version is compatible, please run the following script:

✅ Verification successful

Spellcheck action version update verified.

The update from rojopolis/spellcheck-github-actions@0.40.0 to 0.42.0 does not introduce any breaking changes according to the changelog. Therefore, it's safe to proceed with this version update.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check the changelog of rojopolis/spellcheck-github-actions for any breaking changes

# Fetch the changelog
changelog=$(curl -s https://raw.githubusercontent.com/rojopolis/spellcheck-github-actions/master/CHANGELOG.md)

# Check for breaking changes between versions 0.40.0 and 0.42.0
echo "$changelog" | awk '/## \[0.42.0\]/,/## \[0.40.0\]/' | grep -i "breaking changes"

# If no output, there are likely no breaking changes mentioned in the changelog

Length of output: 51788


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@michelle0927 michelle0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcortes
Copy link
Collaborator Author

jcortes commented Sep 30, 2024

/approve

@jcortes jcortes merged commit c76434d into PipedreamHQ:master Sep 30, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

[BUG] Google calendar - Upcoming Event Alert does not emit new event
2 participants